Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slock: added documentation to nixpkgs manual #23112

Closed
wants to merge 1 commit into from

Conversation

andsild
Copy link
Contributor

@andsild andsild commented Feb 23, 2017

Motivation for this change

Since security.setuidPrograms is deprecated, the wiki should be updated.
Slock wiki issue: #13286
Old wiki entry (which I mostly copied) https://nixos.org/wiki/Slock

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@andsild, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @xvapx and @rbvermaa to be potential reviewers.

@andsild
Copy link
Contributor Author

andsild commented Feb 23, 2017

I was slightly unsure of where to put the documentation but I hope this is a good attempt 🙏

@fpletz
Copy link
Member

fpletz commented Feb 23, 2017

Shouldn't we maybe add a programs.slock module instead? That's also done for mtr or wireshark.

@andsild
Copy link
Contributor Author

andsild commented Feb 23, 2017

@fpletz That sounds even better. I'll try that later and close this PR 👍

@demin-dmitriy
Copy link
Contributor

Want just to note, that I have in my configuration just

wrappers = {
    slock.source = "${pkgs.slock}/bin/slock";
};

I'm not sure, what is "the right way" though.

@andsild
Copy link
Contributor Author

andsild commented Feb 23, 2017

@demin-dmitriy Less is better. I thought I had to put in setuid, didn't think of trying just slock.source

@andsild
Copy link
Contributor Author

andsild commented Mar 31, 2017

Given that the fix for slock is just one line extra to a configuration.nix, I'm tempted to just let this PR rest until I have more time another day. Also, I agree with a comment in #13286 that there should be a more general fix to this so that it is easy for people who get errormessages related to setuid to lookup and identify how to fix it.

@andsild andsild closed this Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants