stanchion: added test #23103
Closed
stanchion: added test #23103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I notice it is not added to the test top-level. Is that intentional? |
fpletz
reviewed
Feb 25, 2017
| startAll; | ||
|
|
||
| $master->waitForUnit("riak"); | ||
| $master->sleep(20); # Hopefully this is long enough!! |
There was a problem hiding this comment.
What are you waiting for here? Shouldn't this rather be fixed in the systemd service?
There was a problem hiding this comment.
Ah, sorry. Systemd does not work with Riak/Stanchion/Riak CS. @LnL7 and I attempted to solve this a few months back, but to no avail.
This is performed similarly to Riak's test.
|
@joachifm apologies, didn't realize there was a top-level test file. I can add that ASAP! |
|
@mdaiter should this also be closed? |
|
@mdaiter do you want to complete this or should we close it for now? |
|
Stalled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Stanchion should have a test for itself.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)