Geany: 1.30 -> 1.30.1 #24067
Merged
Geany: 1.30 -> 1.30.1 #24067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frlan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @bbenoist and @vcunat to be potential reviewers. |
Cosmetic change
ndowens
approved these changes
Mar 19, 2017
Mic92
reviewed
Mar 19, 2017
| buildInputs = [ gtk2 which pkgconfig intltool file ]; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ gtk2 which intltool file ]; |
There was a problem hiding this comment.
intltool also belongs to nativeBuildInputs.
There was a problem hiding this comment.
@Mic92 was thinking it may be, will fix it :) running nox-review right now before I merge
ndowens
previously requested changes
Mar 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR updates Geany to 1.30 as there was a bug found in 1.30 causing e.g. calltips popping up on wrong display when using Geany in a multi-display environment and not running on left top monitor.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)