Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nvidia x11 fixes #24045

Merged
merged 2 commits into from Mar 19, 2017
Merged

Nvidia x11 fixes #24045

merged 2 commits into from Mar 19, 2017

Conversation

deepfire
Copy link
Contributor

Motivation for this change

A couple of errors happen:

  1. when $bin is unset
  2. when libsOnly is specified, /and/ the kernel fails to patch -- libsOnly isn't honoted
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@deepfire, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @vcunat and @edolstra to be potential reviewers.

@deepfire deepfire mentioned this pull request Mar 19, 2017
Closed
@deepfire
Copy link
Contributor Author

The failure is error: a ‘aarch64-linux’ is required to build ‘/nix/store/2ssy7xzn086xdbb5lpwhg611ksbmmmvr-options-db.xml.drv’, but I am a ‘x86_64-linux’, which seems unrelated.

@abbradar
Copy link
Member

Closed in b187163. Thanks!

@abbradar abbradar merged commit d860a68 into NixOS:master Mar 19, 2017
@deepfire deepfire deleted the nvidia-x11-fixes branch March 19, 2017 16:23
@abbradar
Copy link
Member

Backported to release channel along with driver updates (to enable Linux 4.10 support).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepfire @mention-bot @abbradar