direwolf: 1.2 -> 1.3 #24105
direwolf: 1.2 -> 1.3 #24105
Conversation
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny and @zimbatm to be potential reviewers. |
|
@LnL7 Can you see if this works on Darwin? Patched the makefiles for correct output and changed to unix, in hopes it will work; Don't want to merge until I know :) |
| }; | ||
|
|
||
| buildInputs = [ | ||
| unzip alsaLib | ||
| alsaLib espeak perl python |
There was a problem hiding this comment.
alsaLib is a linux only dependency. But it should work fine on other platforms without it, using something like this:
] ++ stdenv.lib.optional stdenv.isLinux alsaLib;
alaLib as optional Remove extra stdenv.lib
|
There is only one binary that doesn't run; it needs adafruit_ads1x15 i believe; So if any one of you want to package that, this will work; otherwise I believe this one works more than what is in the repo; Maybe |
| unzip alsaLib | ||
| ]; | ||
| espeak perl python | ||
| ] optional stdenv.isLinux alsaLib; |
There was a problem hiding this comment.
Does the updated version evaluate? Looks like a typo (missed ++ and I would probably put parentheses around optional call)
|
There is only one binary that doesn't work as it is missing a dep we don't have packaged
…Sent from my iphone
On Mar 24, 2017, 10:27 AM -0500, Michael Raskin ***@***.***>, wrote:
@7c6f434c commented on this pull request.
In pkgs/applications/misc/direwolf/default.nix (#24105 (comment)):
> }; buildInputs = [ - unzip alsaLib - ]; + espeak perl python + ] optional stdenv.isLinux alsaLib;
Does the updated version evaluate? Looks like a typo (missed ++ and I would probably put parentheses around optional call)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24105 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7-C05poPBIKPzR90Q-8KQn8Gq-iDks5ro-DXgaJpZM4Mh92R).
|
|
After the small edit in response to @LnL7 the expression stopped evaluating, I think |
|
Sigh it was all working except one
…Sent from my iphone
On Mar 24, 2017, 11:18 AM -0500, Michael Raskin ***@***.***>, wrote:
After the small edit in response to @LnL7 (https://github.com/LnL7) the expression stopped evaluating, I think
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24105 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL72oHDHaN-51EBptTMvSv6LiRhNIeks5ro-zBgaJpZM4Mh92R).
|
alaLib as optional Remove extra stdenv.lib (@7c6f434c) fixed a typo - pushing instead of NixOS#24105
|
Pushed a fixed-typo version |
Motivation for this change
Update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)