Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

htmldoc: add darwin support #24050

Merged
merged 3 commits into from
Mar 19, 2017
Merged

htmldoc: add darwin support #24050

merged 3 commits into from
Mar 19, 2017

Conversation

shanemikel
Copy link
Contributor

I also added a long description and updated the homepage to point to
the author’s new github.io site.

Please be patient as the first attempt at contributing packaging for Nixpkgs.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

I also added a long description and updated the homepage to point to
the author’s new github.io site.
@mention-bot
Copy link

@shanemikel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Fuuzetsu, @zimbatm and @zraexy to be potential reviewers.

@shanemikel
Copy link
Contributor Author

I'm curious how I was able to remove so many build inputs and still get a working build...

@Mic92
Copy link
Member

Mic92 commented Mar 19, 2017

It seems that the project maintainer vendorize all libraries now instead: https://github.com/michaelrsweet/htmldoc/tree/master/jpeg

This was probably different in previous versions.

Verified

This commit was signed with the committer’s verified signature.
Mic92 Jörg Thalheim
+ "/release-1.8.29/htmldoc-1.8.29-source.tar.gz";
md5 = "14d32bd772e2bc6af7b9b2233724c3ec";
+ "/release-${version}/htmldoc-${version}-source.tar.gz";
sha256 = "15x0xdf487j4i4gfap5yr83airxnbp2v4lxaz79a4s3iirrq39p0";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not use md5 anymore due known hash collision attacks.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Mar 19, 2017
sha256 = "15x0xdf487j4i4gfap5yr83airxnbp2v4lxaz79a4s3iirrq39p0";
};
buildInputs =
stdenv.lib.ifEnable stdenv.isDarwin [SystemConfiguration Foundation];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use stdenv.lib.optionals, I think ifEnable is deprecated

@LnL7 LnL7 merged commit 52c6d67 into NixOS:master Mar 19, 2017
@shanemikel shanemikel deleted the package_htmldoc branch March 19, 2017 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants