-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
htmldoc: add darwin support #24050
htmldoc: add darwin support #24050
Conversation
I also added a long description and updated the homepage to point to the author’s new github.io site.
@shanemikel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Fuuzetsu, @zimbatm and @zraexy to be potential reviewers. |
I'm curious how I was able to remove so many build inputs and still get a working build... |
It seems that the project maintainer vendorize all libraries now instead: https://github.com/michaelrsweet/htmldoc/tree/master/jpeg This was probably different in previous versions. |
+ "/release-1.8.29/htmldoc-1.8.29-source.tar.gz"; | ||
md5 = "14d32bd772e2bc6af7b9b2233724c3ec"; | ||
+ "/release-${version}/htmldoc-${version}-source.tar.gz"; | ||
sha256 = "15x0xdf487j4i4gfap5yr83airxnbp2v4lxaz79a4s3iirrq39p0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not use md5 anymore due known hash collision attacks.
sha256 = "15x0xdf487j4i4gfap5yr83airxnbp2v4lxaz79a4s3iirrq39p0"; | ||
}; | ||
buildInputs = | ||
stdenv.lib.ifEnable stdenv.isDarwin [SystemConfiguration Foundation]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use stdenv.lib.optionals
, I think ifEnable is deprecated
I also added a long description and updated the homepage to point to
the author’s new github.io site.
Please be patient as the first attempt at contributing packaging for Nixpkgs.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)