Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libircclient: disable on darwin #24059

Merged
merged 1 commit into from Mar 19, 2017
Merged

libircclient: disable on darwin #24059

merged 1 commit into from Mar 19, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Mar 19, 2017

Motivation for this change

libircclient does not compile on darwin and caused my unrelated pr check to fail.

Its src/Makefile.in has

libircclient.so: libircclient.o
	$(CC) -shared -s -Wl,-soname,libircclient.so.$(APIVERSION) -o libircclient.so libircclient.o @LDFLAGS@ @LIBS@

which fails with

clang -shared -s -Wl,-soname,libircclient.so.1 -o libircclient.so libircclient.o
ld: warning: option -s is obsolete and being ignored
ld: unknown option: -soname
clang-3.7: error: linker command failed with exit code 1 (use -v to see invocation)
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dezgeg dezgeg merged commit 3caba31 into NixOS:master Mar 19, 2017
@orivej orivej deleted the libircclient branch March 19, 2017 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants