Revert "chirp: 20161018 -> 20170311" #24095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny, @zimbatm and @fpletz to be potential reviewers. |
|
Why? What are you doing?! |
|
I left a comment # in a push
…Sent from my iphone
On Mar 20, 2017, 7:37 AM -0500, Franz Pletz ***@***.***>, wrote:
Why? What are you doing?!
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub (#24095 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7w1ooILgK3s6S4sJad_z_jgZFQ9sks5rnnL0gaJpZM4Mh7xo).
|
|
What? |
|
I left a commented line I planned to remove if it wasn't needed
…Sent from my iphone
On Mar 20, 2017, 8:02 AM -0500, Franz Pletz ***@***.***>, wrote:
What?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub (#24095 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7xz9rRhkXeaHjRCvGLGJyKV3cD3zks5rnnjOgaJpZM4Mh7xo).
|
|
So why revert the commit and push it again? Do you know how to use git? |
|
Also, is there any reason for the immediately-merged PRs? You can just push your commits directly to master and prevent a lot of noise (in the commits as well as in other contributor's emails) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24094