Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neo4j: 3.1.1 -> 3.1.2, minor fixes #24082

Merged
merged 3 commits into from Mar 19, 2017
Merged

neo4j: 3.1.1 -> 3.1.2, minor fixes #24082

merged 3 commits into from Mar 19, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 19, 2017

Motivation for this change
  • Version bump
  • Fix use of deprecated configuration style that caused warning on startup (and will eventually be unsupported, presumably)
  • Fix which package is installed into environment when specifying the neo4j package to use for the service.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@dtzWill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Hinidu, @offlinehacker and @bjornfor to be potential reviewers.

@joachifm joachifm merged commit 1dad430 into NixOS:master Mar 19, 2017
@dtzWill
Copy link
Member Author

dtzWill commented Mar 19, 2017

Thanks! 😁

@joachifm
Copy link
Contributor

I picked these to the release branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @mention-bot @joachifm