codeblocks: 13.12 -> 16.01 #24074
codeblocks: 13.12 -> 16.01 #24074
Conversation
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @linquize, @wkennington and @vcunat to be potential reviewers. |
| }; | ||
|
|
||
| buildInputs = [ automake autoconf libtool pkgconfig file zip wxGTK gtk2 ] | ||
| nativeBuildInputs = [ autoreconfHook pkgconfig ]; | ||
| buildInputs = [ libtool file zip wxGTK gtk2 ] |
There was a problem hiding this comment.
Are zip and libtool (and file) used by the installed application?
Intuitively I feel like they should be build-time-only dependencies used by the build system on the host (so, nativeBuildInputs), but I may be wrong.
There was a problem hiding this comment.
Beware in general, as e.g. some packages link against ${libtool.lib}/lib/libltld.so. EDIT: and file has libmagic...
|
Wasn't sure if libtool was a build only dep or needed by run
…Sent from my iphone
On Mar 24, 2017, 10:24 AM -0500, Michael Raskin ***@***.***>, wrote:
@7c6f434c commented on this pull request.
In pkgs/applications/editors/codeblocks/default.nix (#24074 (comment)):
> }; - buildInputs = [ automake autoconf libtool pkgconfig file zip wxGTK gtk2 ] + nativeBuildInputs = [ autoreconfHook pkgconfig ]; + buildInputs = [ libtool file zip wxGTK gtk2 ]
Are zip and libtool (and file) used by the installed application?
Intuitively I feel like they should be build-time-only dependencies used by the build system on the host (so, nativeBuildInputs), but I may be wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24074 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL72wpENMMMCUazn71OEpiJeL7UfrXks5ro-BEgaJpZM4Mh3TV).
|
(@7c6f434c) move the buildInputs missed in the initial version to nativeBuildInputs, too. Pushed instead of NixOS#24074
|
Checked, not in the closure. |
|
(Pushed the updated version) |
|
Beware in general, as e.g. some packages link against `${libtool.lib}/lib/libltld.so`.
I really hope they don't do it in a complicated static way (there is no
run-time dependency, at least)
|
|
Well, if someone attempted a real cross-compilation and we had this incorrectly, the linking should fail IIRC, whether it's static or dynamic (stuff compiled for different targets). |
|
Well, it was obviously never attempted before, and linking `libltld.so`
statically should be an interesting exercise in build systems anyway.
(I do know that arch mismatch would kill static linking)
|
Motivation for this change
Update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)