gnu global: set path of default gtags.conf in wrapper #24057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNU global's gtags and global tools were unable to find the default gtags.conf, necessary to use gtagslabels. The error could be seen when gtags was invoked with -v: $ gtags -v --gtagslabel=pygments [Sun Mar 19 14:13:17 UTC 2017] Gtags started. Using default configuration. GTAGSLABEL(--gtagslabel) ignored since configuration file not found. Using 'gtags.files' as a file list. [Sun Mar 19 14:13:17 UTC 2017] Creating 'GTAGS' and 'GRTAGS'. [Sun Mar 19 14:13:17 UTC 2017] Done. The wrapper now points to the default gtags.conf using the GTAGSCONF environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GNU global's gtags and global tools were unable to find the default
gtags.conf, necessary to use gtagslabels. The error could be seen
when gtags was invoked with -v:
$ gtags -v --gtagslabel=pygments
[Sun Mar 19 14:13:17 UTC 2017] Gtags started.
Using default configuration.
GTAGSLABEL(--gtagslabel) ignored since configuration file not found.
Using 'gtags.files' as a file list.
[Sun Mar 19 14:13:17 UTC 2017] Creating 'GTAGS' and 'GRTAGS'.
[Sun Mar 19 14:13:17 UTC 2017] Done.
The wrapper now points to the default gtags.conf using the
GTAGSCONF environment variable.
Motivation for this change
The gtagslabel option was not working - it was being silently ignored.
That would be reported when the -v flag was used, though.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)