guitarix: remove webkit, add compile flags #23455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as recomended by the author: https://sourceforge.net/p/guitarix/mailman/message/33688855/
|
@magnetophon, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @codyopel and @FRidh to be potential reviewers. |
|
@vcunat @joachifm As discussed in #23390, a saner version of guitarix, also fixes the build. |
vcunat
requested changes
Mar 5, 2017
|
@vcunat idk why, but this is what the author of guitarix recommends. |
|
Oh, well, maybe better leave it then. |
|
Thank you! Applied in 00ffbf0. |
vcunat
pushed a commit
that referenced
this pull request
Mar 6, 2017
as recomended by the author: https://sourceforge.net/p/guitarix/mailman/message/33688855/ (cherry picked from commit 00ffbf0)
|
Picked to 17.03, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as recomended by the author: https://sourceforge.net/p/guitarix/mailman/message/33688855/
Please merge in 17.03, as the version with webkitgtk2 doesn't build.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)