Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edward: init at 1.2.2 #23452

Merged
merged 1 commit into from Mar 10, 2017
Merged

edward: init at 1.2.2 #23452

merged 1 commit into from Mar 10, 2017

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 3, 2017

Didn't add support for tensorflow with CUDA yet.

Tests currently don't work due to tensorflow weirdness.

Didn't add all optional dependencies.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [N/A] Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@bcdarwin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

FRidh
FRidh requested changes Mar 3, 2017
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move the expression in a separate file in pkgs/development/python-modules/edward/default.nix.

pkgs/top-level/python-packages.nix Outdated
sha256 = "0h9i15l7mczwx8jvabjbvxjjidr13x81h6vylb1p8r308w01r2as";
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you disable the tests, then at least explain here why.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved to python-modules.

@bcdarwin bcdarwin force-pushed the edward branch 2 times, most recently from 946dfb4 to 4a5fa2e Compare March 3, 2017 16:51
@bcdarwin
Copy link
Member Author

Fixed ... Travis build is failing for unrelated reasons.

@FRidh FRidh merged commit 262993d into NixOS:master Mar 10, 2017
@bcdarwin bcdarwin deleted the edward branch March 10, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcdarwin @mention-bot @FRidh