Qt 5.8 and Plasma 5.9 #23446
Merged
Qt 5.8 and Plasma 5.9 #23446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ttuegel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dezgeg, @vandenoever and @vcunat to be potential reviewers. |
Qt 5.8 is now the default version.
Fix build failure with Qt 5.8.0
Build fails with Qt 5.8 due to an ambiguous overloaded member function.
So that pkg-config can be used to find 'moc' etc. (Currently it points to a non-existing path.) Fixes NixOS#22945 ('Linux kbuild incompatible with "nix-shell -p qt5.full"').
|
@bjornfor I added your mass-rebuild Qt patch to this branch. I tweaked it slightly because I missed some Darwin-specific fixes for Qt 5.8 when I updated. The only way this will get tested is if Hydra builds it, so I'm sending it into staging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Package updates:
Testing
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Travis will not be able to rebuild all the dependent packages, but I am rebuilding locally and I will push additional package fixes as necessary.