Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightdm-greeters service: add extraConfig option. #24135

Merged
merged 1 commit into from Mar 22, 2017
Merged

lightdm-greeters service: add extraConfig option. #24135

merged 1 commit into from Mar 22, 2017

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 20, 2017

Motivation for this change

Allow greater customisation of lightdm's greeter. For my particular use case I wish to append

xft-dpi=192

to the configuration file to have lightdm scale on a hidpi screen. This is currently not exposed via any of the existing options.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@pbogdan, thanks for your PR! By analyzing the history of the files in this pull request, we identified @TimoMeijer, @edolstra and @lethalman to be potential reviewers.

@fpletz fpletz changed the title lightdm-greeters service : add extraConfig option. lightdm-greeters service: add extraConfig option. Mar 22, 2017
@fpletz fpletz merged commit a4b4cd0 into NixOS:master Mar 22, 2017
@pbogdan pbogdan deleted the lightdm-gtk-greeter-extra-config branch December 3, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants