Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwknop: init at 2.6.9 #24132

Merged
merged 2 commits into from Mar 21, 2017
Merged

fwknop: init at 2.6.9 #24132

merged 2 commits into from Mar 21, 2017

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 20, 2017

Please don't merge this yet (should be fine but I didn't test the final executables yet, at least not enough).

(TODO: Patch sysconfdir and localstatedir.)

Motivation for this change

Add a great tool for SPA (think of it as an advanced/improved version of port knocking) 馃槃

Most (hopefully all) things should be ok, but since I'm still a relatively new to NixOS I thought it would be great if someone could double check it. I guess a quick look over the code/changes should be enough, I can take the responsibility for the building and final executables. Feel free to drop a note if you want to merge this (for some reason :D) if not I can merge it myself after I've finished testing the executables.

@Fuuzetsu - I guess the change for gpgme is ok but please let me know if I missed anything - thanks 馃槃

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

  • (same location as e.g. fail2ban) package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on AMD64
  • executables tested on AMD64
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • (limited to Linux (iptables) for now) meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • (no patches used) patches that are remotely available are fetched with fetchpatch

@mention-bot
Copy link

@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aszlig, @urkud and @Fuuzetsu to be potential reviewers.

@primeos primeos force-pushed the fwknop branch 2 times, most recently from f84f7ec to db8d4b5 Compare March 21, 2017 21:18
This shouldn't break anything as currently neither dev nor info will be
generated anyway (since both directories don't actually exist at the
install phase - "mv bin dev" would produce the dev output).

This change is required for building fwknop with GnuPG support.
fwknop stands for the "FireWall KNock OPerator", and implements an
authorization scheme called Single Packet Authorization (SPA).
@c0bw3b
Copy link
Contributor

c0bw3b commented Mar 21, 2017

Signaled by @calvertvl on IRC and confirmed here :
8727702 broke fwupd since it relies on gpgme.dev

@primeos
Copy link
Member Author

primeos commented Mar 21, 2017

@c0bw3b Yes, thanks for letting me know as well 馃槃 - Fixed (i.e. mainly reverted) in 4e29638 - I've had a stupid misconception... 馃檲 - I hope something like this won't happen again anytime soon.

@c0bw3b
Copy link
Contributor

c0bw3b commented Mar 22, 2017

@primeos it's on master and it was fixed in a jiffy so nothing too serious here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants