Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Confirm error messages in senderror exist #2434

Closed
ianb opened this issue Mar 20, 2017 · 1 comment
Closed

Confirm error messages in senderror exist #2434

ianb opened this issue Mar 20, 2017 · 1 comment
Milestone
Stretch

Comments

@ianb
Copy link
Contributor

ianb commented Mar 20, 2017

In messages we have a long list of messages. Not all are being used (e.g., #2433), but all of them should be. A simple grep should clarify if they are being used.
@ghost ghost added this to the Stretch milestone Mar 22, 2017
@ianb ianb self-assigned this Mar 27, 2017
@ianb
Copy link
Contributor Author

ianb commented Mar 28, 2017 •
edited

Current status:

  • REQUEST_ERROR
  • CONNECTION_ERROR
  • LOGIN_ERROR
  • LOGIN_CONNECTION_ERROR
  • UNSHOOTABLE_PAGE
  • SHOT_PAGE
  • MY_SHOTS

@dannycoates might need to use SHOT_PAGE, MY_SHOTS, UNSHOOTABLE_PAGE for context menu errors. Also these might be good titles for the button when it is disabled?

@ianb ianb removed their assignment Mar 28, 2017
@ianb ianb assigned ianb and unassigned ianb Apr 10, 2017
@ianb ianb closed this as completed Jul 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Stretch
Development

No branches or pull requests
1 participant
@ianb