Added option and description for nix store auto-optimisation. #24134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pstn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @MarcWeber and @peti to be potential reviewers. |
|
For reference, fixed up and picked to 17.03 as of e87e108. |
fpletz
reviewed
Mar 21, 2017
| @@ -46,6 +46,7 @@ let | |||
| binary-caches = ${toString cfg.binaryCaches} | |||
| trusted-binary-caches = ${toString cfg.trustedBinaryCaches} | |||
| binary-cache-public-keys = ${toString cfg.binaryCachePublicKeys} | |||
| auto-optimise-store = ${toString cfg.autoOptimiseStore} | |||
There was a problem hiding this comment.
This causes nixops deploy to fail:
gitlab............> error: configuration option ‘auto-optimise-store’ should be either ‘true’ or ‘false’, not ‘’
gitlab............> error: configuration option ‘auto-optimise-store’ should be either ‘true’ or ‘false’, not ‘’
gitlab............> unable to connect to ‘root@git.mayflower.de’; falling back to old closure copying method
gitlab............> error: configuration option ‘auto-optimise-store’ should be either ‘true’ or ‘false’, not ‘’
gitlab............> Died at /nix/store/pjk50qzcs5n3x43q8hb4556g4xm22rr3-nix-1.11.7/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi/Nix/CopyClosure.pm line 100.
I have a fix that I will push in a few minutes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I didn't know of the auto-optimise functionality until today. Adding it as an option with a description makes it much more discoverable. Description is from
man nix.confThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)