Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Should bootstrap.js errors be sent to Sentry? #2420

Closed
jaredhirsch opened this issue Mar 18, 2017 · 2 comments
Closed

Should bootstrap.js errors be sent to Sentry? #2420

jaredhirsch opened this issue Mar 18, 2017 · 2 comments
Milestone

Comments

@jaredhirsch
Copy link
Member

It might be useful to log bootstrap.js errors to Sentry, since the WebExtension could fail to load.

I'm not sure how to do this, because the setup code lives inside the WebExtension, and assumes auth has returned the Sentry info. Can we hard-code the Sentry information in the addon, or do we always need to fetch it from the server?

FWIW, I've figured out how to load raven.js inside the bootstrap file:

let Raven;
function initRaven() {
  const { require } = Cu.import("resource://gre/modules/commonjs/toolkit/require.js", {})
  AddonManager.getAddonByID(ADDON_ID).then((addon) => {
    Raven = require(addon.getResourceURI().asciiSpec + 'webextension/build/raven.js');
  });
}
@ckprice ckprice added this to the Next Tasks milestone Mar 20, 2017
@ckprice
Copy link

ckprice commented Mar 20, 2017

Ian noted that having Raven run in the high privileged could be a security risk.

@ghost ghost modified the milestones: Next Tasks, Blue Sky Jun 28, 2017
@ianb
Copy link
Contributor

ianb commented Jan 10, 2018

This is too hard and too dangerous given the potential benefits.

@ianb ianb closed this as completed Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants