Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

iframe is not destroyed when WebExtension is shutdown #2421

Closed
jaredhirsch opened this issue Mar 18, 2017 · 2 comments
Closed

iframe is not destroyed when WebExtension is shutdown #2421

jaredhirsch opened this issue Mar 18, 2017 · 2 comments
Labels
code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox
Milestone
Backlog

Comments

@jaredhirsch
Copy link
Member

When the WebExtension is disabled, the bootstrap code needs to send a signal to tell the WebExtension, and the WebExtension should tear down any iframes it has added.

Steps to reproduce:

  1. start firefox with pageshot enabled
  2. open example.com
  3. hit pageshot button, iframe appears over page
  4. open about:config & disable the webextension by setting the extensions.pageshot.disabled boolean pref to true
  5. switch back to the example.com tab: the iframe is still there, but all the JS has been unloaded, so you can't get rid of it without a page refresh
@ckprice ckprice added this to the Next Tasks milestone Mar 20, 2017
@ckprice
Copy link

ckprice commented Mar 20, 2017

Don't think we can do, but we could ask in #team-addons

@ghost ghost modified the milestones: Next Tasks, Blue Sky Jun 28, 2017
@ianb ianb added code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox labels Jan 10, 2018
@ianb
Copy link
Contributor

ianb commented Jan 17, 2018

Because we don't do much updating, this doesn't feel important. Someone would have to work pretty hard to find this bug now, and it's just a harmless unfunctional interface.

@ianb ianb closed this as completed Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
code Code quality issue, that does not have any outward effect on the product firefox Something that has to ship in the add-on in Firefox
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@ianb @jaredhirsch @ckprice