Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 0xdeadbeef pointer format in CallStack.print_frame #4170

Merged
merged 1 commit into from Mar 21, 2017
Merged

Use 0xdeadbeef pointer format in CallStack.print_frame #4170

merged 1 commit into from Mar 21, 2017

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Mar 20, 2017

Before:

Invalid memory access (signal 11) at address 0x20
[4385788459] *CallStack::print_backtrace:Int32 +107
[4385717580] __crystal_sigfault_handler +60
[140735821145386] _sigtramp +26
[4391097761] GC_realloc +50
[4385645403] __crystal_realloc +11
[4385960268] *Pointer(UInt8)@Pointer(T)#realloc<Int32>:Pointer(UInt8) +28
[4387606531] *Foo::Bar#bar!:Nil +195
[4385744993] *naughty_bar:Nil +17
[4385744969] *naughty_foo:Nil +9
[4385645324] __crystal_main +2940
[4385715144] main +40

now:

Invalid memory access (signal 11) at address 0x20
[0x1057a9fab] *CallStack::print_backtrace:Int32 +107
[0x105798aac] __crystal_sigfault_handler +60
[0x7fff9ca0652a] _sigtramp +26
[0x105cb35a1] GC_realloc +50
[0x1057870bb] __crystal_realloc +11
[0x1057d3ecc] *Pointer(UInt8)@Pointer(T)#realloc<Int32>:Pointer(UInt8) +28
[0x105965e03] *Foo::Bar#bar!:Nil +195
[0x10579f5c1] *naughty_bar:Nil +17
[0x10579f5a9] *naughty_foo:Nil +9
[0x10578706c] __crystal_main +2940
[0x105798128] main +40

@Sija Sija force-pushed the format-callstack-pointers branch from 0fe2b82 to 6d9c3cb Compare March 21, 2017 05:32
@Sija Sija mentioned this pull request Mar 21, 2017
Merged
@bcardiff bcardiff added this to the Next milestone Mar 21, 2017
@bcardiff bcardiff merged commit ae678b2 into crystal-lang:master Mar 21, 2017
@bcardiff
Copy link
Member

0xdeadbeef 😂 🍖 . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
topic:stdlib
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Sija @bcardiff