Nginx alias directive #23672
Merged
Nginx alias directive #23672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 9, 2017 13:02
It's like root, but doesn't keep the prefix.
If both are set, nginx won't start. More error checking is certainly in order, but this seems like a reasonable start.
|
@edanaher, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin, @domenkozar and @fadenb to be potential reviewers. |
fadenb
approved these changes
Mar 9, 2017
fpletz
reviewed
Mar 9, 2017
| @@ -158,6 +158,7 @@ let | |||
| server_name ${serverName} ${concatStringsSep " " vhost.serverAliases}; | |||
| ${acmeLocation} | |||
| ${optionalString (vhost.root != null) "root ${vhost.root};"} | |||
| ${optionalString (vhost.alias != null) "alias ${vhost.alias};"} | |||
There was a problem hiding this comment.
Have you checked whether alias works in a server? According to the docs, it should only work in location blocks.
There was a problem hiding this comment.
Huh; I thought I tested it, but I must have missed something. That bit is now removed.
|
This is a nice addition we can IMHO safely backport to 17.03. /cc @globin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
While it's easy enough to add extraConfig = "alias = ${alias};", why not make it even easier?
For example, I'm using this to serve a robots.txt straight from pkgs.writeText; that's a really neat trick. With the "root" directive, this doesn't work because nginx will look for ${robots.txt}/robots.txt; with alias, it serves the file path with no modification.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)