Feat termdown at 1.11.0 #23403
Closed
Feat termdown at 1.11.0 #23403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clemensmanert, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
ndowens
suggested changes
Mar 2, 2017
| name = "termdown-${version}"; | ||
| version = "1.11.0"; | ||
|
|
||
| src = pkgs.fetchFromGitHub { |
There was a problem hiding this comment.
Shouldn't need src = pkgs.fetchFromGitHub, can simply be src = fetchFromGitHub
|
|
||
| propagatedBuildInputs = [ dateutil click pyfiglet ]; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
You can do meta = with stdenv.lib; {
That way you don't have to write stdenv.lib in licenses and platforms
clemensmanert
force-pushed
the
feat-termdown-at-1.11.0
branch
from
e026c94
to
7a46f15
Compare
grahamc
requested changes
Mar 7, 2017
| @@ -0,0 +1,27 @@ | |||
| { pkgs, stdenv, fetchFromGitHub, buildPythonApplication, | |||
There was a problem hiding this comment.
Please don't pass in pkgs, since you've passed in all your dependencies.
FRidh
requested changes
Mar 7, 2017
| @@ -25935,6 +25935,8 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| termdown = callPackage ../applications/misc/termdown {}; | |||
There was a problem hiding this comment.
Python applications are not called via python-packages.nix but directly from all-packages.nix.
| version = "1.11.0"; | ||
|
|
||
| src = fetchFromGitHub { | ||
| rev = "d1e3504e02ad49013595112cb03fbf175822e58d"; |
| propagatedBuildInputs = [ dateutil click pyfiglet ]; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Starts a countdown to or from TIMESPEC"; |
|
Fixed the style issues and pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Init termdown 1.11.0
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)