Update and improve Mono #23295

abbradar · 2017-02-28T20:43:39Z

Motivation for this change

Update Mono and add more system libraries;
Drop old versions of Mono as they are unused throughout the tree;
Add a headless version with a much smaller closure;
Build previously prebuilt parts of Mono from source.

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

I'll try to upstream use-dllmap-everywhere.patch. See mono/mono#4451.

vbgl · 2017-03-01T04:16:53Z

pkgs/development/compilers/mono/default.nix

+, withCUPS ? true, cups
+, withALSA ? true, alsaLib
+, withLLVM ? true
+}:


The three options withCUPS, withALSA and withLLVM should default to false on Darwin (i.e., using stdenv.isLinux or !stdenv.isDarwin).

Updated, thanks!

No. withLLVM should be false on darwin. withX11 can be true.

I see, thank you for double-checking. Fixed, also made it so that GTK and friends aren't used on Darwin -- does that sound right?

vbgl · 2017-03-02T06:44:06Z

This breaks boogie; its build now fails with the following error (and 12 other similar ones):

BigDecTests.cs(28,10): error CS0616: `NUnit.Framework.TestCase': is not an attribute class

This probably comes from an API change in the NUnit library.

abbradar · 2017-03-03T10:42:39Z

The patch was upstreamed, I removed it from the tree.

@vbgl I'll look into this, thanks! Sadly I don't have resources to fuly run nox-review now (I'll have a chance soon).

Bundled LLVM: 3.4svn-mono-f9b1a74368 -> 3.6-mono-2017-02-15 Remove old Mono versions. Add options to enable GTK, SVG and printing support. Build reference assemblies from source (essentially Mono 3.12.1 stripped from actual method bodies). Add headless version. Should improve support of color schemas in Windows Forms.

abbradar · 2017-04-13T16:50:32Z

Sorry for a long response -- I've tried to look at it back now and then but I don't have a good idea how can I fix this. I think I understand what needs to be fixed -- we need to use NUnit 2 for Boogie instead of Mono's unit. Still, placing dotnetPackages.NUnit2 to buildInputs does nothing.

kuznero · 2017-04-26T04:23:02Z

I just submitted 2 pull requests on introducing mono 4.6.2 and 4.8(.1) not knowing that there is this pull request already on improving mono:

4.6.2
4.8

Should we consider joining the effort? I planned to submit mono50 later today as well. And fsharp41 had been submitted and merged a couple of weeks ago (this was the part of the change to upgrade mono).

abbradar · 2017-04-26T11:45:14Z

@kuznero With pleasure! I'm not sure how to fix the problem with Boogie. BTW, are old Mono versions (like 4.6.2) needed? They are unused in the tree but perhaps they are useful for users in some way I don't know?

kuznero · 2017-04-26T13:18:06Z

@abbradar 4.6.2 is probably the most widely used version of the runtime as far as I know. So, supporting it would make sense in general for others to use I guess. And yes, it is done as new packages, so nothing depends on it at the moment and it should go pretty painless. Unfortunately I see some of the builds failing (4.6.2 and 5.0), but 4.8 is green.

abbradar · 2017-04-27T12:38:49Z

@kuznero Do I understand correctly that Mono is incompatible between versions (because I supposed otherwise)? Then yes, let's leave the most popular runtime be.

copumpkin · 2017-04-28T20:24:33Z

@kuznero would you still support killing 4.0 and 4.4?

kuznero · 2017-04-28T21:16:51Z

@copumpkin I would keep 4.0 but discontinue 4.4

copumpkin · 2018-01-04T15:15:26Z

Any progress here? Also, anyone have plans to package 5.4?

abbradar · 2018-05-08T13:42:46Z

I'm not motivated enough to rebase this for now; this is still definitely relevant but needs moderate work.

baracoder · 2018-08-30T16:57:06Z

This looks related to #36711

obadz · 2018-12-23T01:19:19Z

Some parts of this are superseded by #52712 but there are some cool things in here such as:

Bundled LLVM: 3.4svn-mono-f9b1a74368 -> 3.6-mono-2017-02-15
Build reference assemblies from source (essentially Mono 3.12.1 stripped from actual method bodies).
Some Darwin work

@obadz

Also now builds with --enable-llvmloaded. Extracted by @obadz from @abbradar's NixOS#23295 NixOS@d27768a

bobvanderlinden · 2019-04-13T21:33:43Z

I think this PR may be closed. Most of the features in this PR are on master.

felschr · 2020-03-14T11:35:11Z

Please rebase your changes. Otherwise, I'd suggest closing the PR.
As far as I can see the only changes that aren't on master already are the withX options and the headless variant.

libgdiplus: 2.10.9 -> 4.2

91c0815

abbradar added the 8.has: package (update) label Feb 28, 2017

vbgl reviewed Mar 1, 2017

View reviewed changes

abbradar force-pushed the mono branch 2 times, most recently from b32da29 to 632132d Compare March 1, 2017 10:53

abbradar force-pushed the mono branch from 632132d to 7718ce6 Compare March 2, 2017 11:06

abbradar force-pushed the mono branch from 7718ce6 to d27768a Compare March 3, 2017 10:47

obadz mentioned this pull request Dec 23, 2018

mono: drop minor versions and upgrade to 5.16.0.220 #52712

Merged

10 tasks

obadz added a commit to obadz/nixpkgs that referenced this pull request Dec 23, 2018

mono: llvm fork update 3.4svn-mono-f9b1a74368 -> 3.6-mono-2017-02-15

013927f

Also now builds with --enable-llvmloaded. Extracted by @obadz from @abbradar's NixOS#23295 NixOS@d27768a

domenkozar closed this Jul 20, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update and improve Mono #23295

Update and improve Mono #23295

abbradar commented Feb 28, 2017 •

edited

vbgl Mar 1, 2017

abbradar Mar 1, 2017

vbgl Mar 1, 2017

abbradar Mar 1, 2017

vbgl commented Mar 2, 2017

abbradar commented Mar 3, 2017 •

edited

abbradar commented Apr 13, 2017

kuznero commented Apr 26, 2017

abbradar commented Apr 26, 2017

kuznero commented Apr 26, 2017

abbradar commented Apr 27, 2017 •

edited

copumpkin commented Apr 28, 2017

kuznero commented Apr 28, 2017

copumpkin commented Jan 4, 2018

abbradar commented May 8, 2018

baracoder commented Aug 30, 2018

obadz commented Dec 23, 2018 •

edited

bobvanderlinden commented Apr 13, 2019

felschr commented Mar 14, 2020

Update and improve Mono #23295

Update and improve Mono #23295

Conversation

abbradar commented Feb 28, 2017 • edited

Motivation for this change

Things done

vbgl Mar 1, 2017

Choose a reason for hiding this comment

abbradar Mar 1, 2017

Choose a reason for hiding this comment

vbgl Mar 1, 2017

Choose a reason for hiding this comment

abbradar Mar 1, 2017

Choose a reason for hiding this comment

vbgl commented Mar 2, 2017

abbradar commented Mar 3, 2017 • edited

abbradar commented Apr 13, 2017

kuznero commented Apr 26, 2017

abbradar commented Apr 26, 2017

kuznero commented Apr 26, 2017

abbradar commented Apr 27, 2017 • edited

copumpkin commented Apr 28, 2017

kuznero commented Apr 28, 2017

copumpkin commented Jan 4, 2018

abbradar commented May 8, 2018

baracoder commented Aug 30, 2018

obadz commented Dec 23, 2018 • edited

bobvanderlinden commented Apr 13, 2019

felschr commented Mar 14, 2020

abbradar commented Feb 28, 2017 •

edited

abbradar commented Mar 3, 2017 •

edited

abbradar commented Apr 27, 2017 •

edited

obadz commented Dec 23, 2018 •

edited