libseccomp: 2.3.1 -> 2.3.2 + fixed scmp_sys_resolver #23303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@c0bw3b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @fpletz and @wkennington to be potential reviewers. |
c0bw3b
commented
Feb 28, 2017
|
|
||
| patchPhase = '' | ||
| patchShebangs . | ||
| ''; | ||
|
|
||
| postInstall = '' | ||
| wrapProgram $out/bin/scmp_sys_resolver --prefix LD_LIBRARY_PATH ":" $out/lib |
There was a problem hiding this comment.
That postInstall action can be reported on the previous version of the package on stable channels (16.09 and 17.03) in order to make the scmp_sys_resolver command work. It also needs the makeWrapper build input.
|
With the wrapProgram on
|
|
@fpletz @thoughtpolice for reviewing this since you updated libseccomp before. ChangeLogVersion 2.3.2 - February 27, 2017
|
`libseccomp` is updated to 2.3.2 `scmp_sys_resolver` is fixed (it could not find libseccomp.so.2 shared library before)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
libseccompis updated to 2.3.2scmp_sys_resolveris fixed (it could not find libseccomp.so.2 shared library before)Up to now the
scmp_sys_resolvercommand was not working because the bin could not find its shared lib :Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)