Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwinfo: 21.23 -> 21.38 #23319

Closed
wants to merge 1 commit into from
Closed

hwinfo: 21.23 -> 21.38 #23319

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 1, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bobvanderlinden to be a potential reviewer.

@c0bw3b
Copy link
Contributor

c0bw3b commented Mar 1, 2017

Hello,
I tried to build that and run the binaries produced. hwinfo works fine :

[demo@nixos:~/testbuilds/hwinfo]$ ./result/bin/hwinfo --version
21.38

But two other commands gives unexpected results :

[demo@nixos:~/testbuilds/hwinfo]$ ./result/bin/mk_isdnhwdb
Cannot open /usr/share/hwinfo/ISDN.CDB.txt as stdin

The path /usr/share does not exist under NixOS.

[demo@nixos:~/testbuilds/hwinfo]$ ./result/bin/convert_hd
Can't locate XML/Writer.pm in @inc (you may need to install the XML::Writer module) (@inc contains: /home/demo/.nix-profile/lib/perl5/site_perl /nix/var/nix/profiles/default/lib/perl5/site_perl /run/current-system/sw/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /run/current-system/sw/lib/perl5/site_perl/5.22.2 /run/current-system/sw/lib/perl5/site_perl /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2 /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2 .) at ./result/bin/convert_hd line 4.
BEGIN failed--compilation aborted at ./result/bin/convert_hd line 4.

A Perl module is missing.

@bjornfor
Copy link
Contributor

bjornfor commented Mar 1, 2017

The two other commands, did they work before? (If this PR does not cause regressions, we merge it even if some things are broken.)

@bobvanderlinden
Copy link
Member

I don't think the other commands ever worked. I wasn't aware they existed nor what their use is (can't find them in man). I can check them out tonight.

@c0bw3b
Copy link
Contributor

c0bw3b commented Mar 1, 2017

Those two commands never worked indeed. I did not mean to imply it was a regression of this PR. :)
Just wanted to point that out so we know there is room for improvement in a future PR on this package.

]$ nix-env -iA nixos.hwinfo
[demo@nixos:~/testbuilds]$ hwinfo --version
21.23
]$ mk_isdnhwdb
Cannot open /usr/share/hwinfo/ISDN.CDB.txt as stdin
]$ convert_hd
Can't locate XML/Writer.pm in @inc (you may need to install the XML::Writer module) (@inc contains: /home/demo/.nix-profile/lib/perl5/site_perl /nix/var/nix/profiles/default/lib/perl5/site_perl /run/current-system/sw/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /run/current-system/sw/lib/perl5/site_perl/5.22.2 /run/current-system/sw/lib/perl5/site_perl /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/site_perl/5.22.2 /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2/x86_64-linux-thread-multi /nix/store/p7k810475bbk0v9wi418sz8jh3dzlpiz-perl-5.22.2/lib/perl5/5.22.2 .) at /home/demo/.nix-profile/bin/convert_hd line 4.
BEGIN failed--compilation aborted at /home/demo/.nix-profile/bin/convert_hd line 4.

@bjornfor bjornfor self-assigned this Mar 1, 2017
@bjornfor
Copy link
Contributor

bjornfor commented Mar 1, 2017

Thanks! Pushed to master (d12030d) and release-17.03 (d60e77f).

@bjornfor bjornfor closed this Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants