Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount: 2.2.0 -> 2.2.2 #23312

Merged
merged 1 commit into from Mar 2, 2017
Merged

Discount: 2.2.0 -> 2.2.2 #23312

merged 1 commit into from Mar 2, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 1, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zimbatm, @rbvermaa and @wkennington to be potential reviewers.

@peterhoeg
Copy link
Member

Please:

  • rename the PR in line with policy
  • the dos2unix commit is already in another PR, so it needs to go

@ndowens
Copy link
Contributor Author

ndowens commented Mar 1, 2017

Crap keep "mistyping" this is an update will fix

@ndowens ndowens changed the title Discount Discount: 2.2.0 -> 2.2.2 Mar 1, 2017
@peterhoeg
Copy link
Member

This commit only adds empty lines.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 1, 2017

Ugh. Will fix when off of work. Guess something weird happened with got or something because I knew I did more than add spaces 😀

Discount: added missing update
@ndowens
Copy link
Contributor Author

ndowens commented Mar 1, 2017

@peterhoeg there we go

@peterhoeg peterhoeg merged commit 0d936b0 into NixOS:master Mar 2, 2017
@ndowens ndowens deleted the discount branch March 2, 2017 02:40
@ndowens ndowens restored the discount branch March 2, 2017 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants