Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea.*: remove old versions #23297

Closed
wants to merge 6 commits into from
Closed

Conversation

GauthierPLM
Copy link
Contributor

Motivation for this change

Remove old version of JetBrains IDEs, no longer updated by JetBrains (and at least 3 majors versions has been released since this versions).

I splited #23081 to avoid confusion between version bump and clean-up.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Kendos-Kenlen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @chris-martin and @globin to be potential reviewers.

Copy link
Contributor

@jpierre03 jpierre03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to delete old idea-community edition

Copy link
Contributor

@jpierre03 jpierre03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to use a Idea14-ultimate edition directly from nixos.
Can thoses packages be removed when jetbrains will stop providing thoses files ?

@GauthierPLM
Copy link
Contributor Author

@jpierre03 as far as I know, they keep distributing old versions indefinitely, for users who bought a particular version of the IDE and who don't want to upgrade to a newer version.
However, this versions are no longer officially maintained and will no longer receive updates.

@jpierre03
Copy link
Contributor

@Kendos-Kenlen Ok. Let's delete it !

@chris-martin
Copy link
Contributor

chris-martin commented Mar 3, 2017

Please don't remove the old versions of the ultimate packages. I have a license for idea15-ultimate, and I still use it every once in a while when I need a feature that isn't in the community edition.

@GauthierPLM
Copy link
Contributor Author

Mmmmh...
Personally I still think keeping outdated and unmaintained versions is not a good thing, however if there is still people using them, it is probably better to keep them in place for a while, or maybe split the package between the current and old versions.

@chris-martin
Copy link
Contributor

Yes, having a separate namespace so that you have to go out of your way a bit to use old versions seems fair.

@edwtjo
Copy link
Member

edwtjo commented Mar 27, 2017

@chris-martin is there any reason (now) you cannot just import and older rev. of nixpkgs, since they're supposedly not receiving updates anymore?

@chris-martin
Copy link
Contributor

@edwtjo I would then have to do some additional customization to merge it into the new package set to avoid running in an outdated JRE, right?

@Mic92
Copy link
Member

Mic92 commented Apr 17, 2017

@chris-martin you can just copy the nix expression and put into packagesOverride. That way java version would be up to date.

@edwtjo
Copy link
Member

edwtjo commented Sep 20, 2017

Closed via 5a6939f 352855e 88de0e4 e1cab6b

Thanks!

@edwtjo edwtjo closed this Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants