Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript: pin dependencies witih callHackage. Closes #23036. #23301

Closed
wants to merge 1 commit into from

Conversation

teh
Copy link
Contributor

@teh teh commented Feb 28, 2017

Motivation for this change

Only tested on GHC 8.0.2 because of limited laptop computing power.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@teh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @mdorman and @pikajude to be potential reviewers.

@domenkozar
Copy link
Member

Doesn't this mean we use import-from-derivation on Hydra?

@domenkozar domenkozar added this to the 17.03 milestone Mar 2, 2017
@peti
Copy link
Member

peti commented Mar 2, 2017

I would assume that Hydra just won't compile that package in its current form. IFD won't be evaluated due to Hydra running Nix in "restricted mode".

@peti
Copy link
Member

peti commented Mar 2, 2017

What's worrying though are the the build errors of the Nixpkgs tarball on Travis-CI. Are those genuine?

@domenkozar
Copy link
Member

I don't think that's the case, it's just encouraged not to be used: NixOS/nix#1122

@teh
Copy link
Contributor Author

teh commented Mar 2, 2017

Ah right, I think I misunderstood the instructions, the configuration-hackage2nix.yaml is required. I'll update.

@teh
Copy link
Contributor Author

teh commented Mar 2, 2017

Closing in favour of https://github.com/peti/nixpkgs/pull/64/files

@teh teh closed this Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants