Skip to content

Commit

Permalink
openisns: fix empty lib output
Browse files Browse the repository at this point in the history
Looks like enable-shared defaults to false, so we actually
ended up with no usable object files in the lib output.

This also appears to have broken open-iscsi, as evinced by

/nix/store/[...]-binutils-2.27/bin/ld: cannot find -lisns
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:57: iscsid] Error 1

https://hydra.nixos.org/build/49437400/log/raw

With this patch, open-iscsi builds fine here.
  • Loading branch information
joachifm committed Mar 1, 2017
1 parent 5e074f1 commit ab6d358
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkgs/os-specific/linux/open-isns/default.nix
Expand Up @@ -15,6 +15,8 @@ stdenv.mkDerivation rec {
outputs = [ "out" "lib" ];
outputInclude = "lib";

configureFlags = [ "--enable-shared" ];

installFlags = "etcdir=$(out)/etc vardir=$(out)/var/lib/isns";
installTargets = "install install_hdrs install_lib";

Expand Down

0 comments on commit ab6d358

Please sign in to comment.