Change Spec::JUnitFormatter to use XML::Builder #4090
Conversation
|
@RX14 Nice, thank you! Just one question before merging this: you say " along with removing some characters which cannot be represented in XML from the spec names"... but I can't seem to find that change in the diff. Where is it? (or is this accomplished just by using |
|
@asterite its just confusing wording.
I thought it was best to seperate the changes into 2 prs, as they have different scopes. Also I wanted to get this merged, and #4089 fixed before working on sanitizing spec names. |
|
Oh, I see! Then can I merge this? :-) |
|
Yes, this pr is complete. |
This means that the generated XML will be properly indented, and always valid. It's also neater.
I've also included a commit which edits the Makefile to allow
make spec junit_output=path/to/dirto pass--junit_outputto the built spec binary.These changes are required for displaying spec results on jenkins, along with removing some characters which cannot be represented in XML from the spec names: https://github.com/crystal-lang/crystal/blob/master/spec/std/uri_spec.cr#L199.