Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Verify add-on behavior for special pages #2236

Closed
ianb opened this issue Feb 28, 2017 · 1 comment · Fixed by #2368
Closed

Verify add-on behavior for special pages #2236

ianb opened this issue Feb 28, 2017 · 1 comment · Fixed by #2368
Assignees
@dannycoates
Milestone
General Release 55

Comments

@ianb
Copy link
Contributor

ianb commented Feb 28, 2017

We should test about: pages, data: pages, moz-extension: pages, and pages that have a <frameset>

Probably most of these pages should just emit an error, though data: or file: pages should be okay.
@ckprice ckprice added this to the Page Shot in 54 milestone Mar 1, 2017
@ianb ianb mentioned this issue Mar 1, 2017
Closed
@ianb ianb self-assigned this Mar 3, 2017
@ianb
Copy link
Contributor Author

ianb commented Mar 3, 2017 •
edited

Current experience for:

  • file URL: works fine
  • data URL: does not work, gives an error in loadSelector: Error: No window matching {"matchesHost":["<all_urls>"]} – probably we should file this as a bug against WebExtensions. To test do View Image on one of the images in this page.
  • moz-extension URL: does not work. Same error as from data:. This URL probably won't be stable, but here's an example from Page Shot. Bug 1271354 covers this case.
  • about URL: same error again. Doesn't matter if it's an HTML page (e.g., about:debugging) or a XUL page (I think about:config).
  • frameset: doesn't work but doesn't give any error. Example page

For frameset I think we should figure out how to detect it. For the other examples we should probably check in with WebExtension people about what we can do and what we can expect.

@ianb ianb removed their assignment Mar 3, 2017
Closed
@dannycoates dannycoates self-assigned this Mar 13, 2017
@dannycoates dannycoates mentioned this issue Mar 13, 2017
Merged
@ianb ianb mentioned this issue Mar 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dannycoates dannycoates

Labels
None yet
Projects
None yet
Milestone
General Release 55
Development

Successfully merging a pull request may close this issue.

disable the pageshot button on about,data,moz-extension pages dannycoates/pageshot
3 participants
@ianb @dannycoates @ckprice