Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Reimplement error message when shooting Page Shot pages #2237

Closed
ianb opened this issue Feb 28, 2017 · 2 comments
Closed

Reimplement error message when shooting Page Shot pages #2237

ianb opened this issue Feb 28, 2017 · 2 comments
Labels
good first issue
Milestone
Sprint 54.3

Comments

@ianb
Copy link
Contributor

ianb commented Feb 28, 2017

Page Shot should give an error of some sort when you try to capture a Page Shot page. Or we could disable the button on those pages (perhaps the better answer, if it's not too hard).
@ckprice ckprice added this to the Page Shot in 54 milestone Mar 1, 2017
@ianb
Copy link
Contributor Author

ianb commented Mar 1, 2017 •
edited

Note that the location of the service is in addon/webextension/background/main.js in main.getBackend() – if the button (browserAction) can be disabled anytime the active tab is on that domain then that would be great, if that's not possible then you can also just pop up an error message if someone attempts to start Page Shot on one of those pages.

@ianb ianb modified the milestones: Page Shot in 54, Sprint 54.2 Mar 9, 2017
@ianb ianb mentioned this issue Mar 14, 2017
Merged
@ghost ghost modified the milestones: Sprint 54.2, Sprint 54.3 Mar 20, 2017
@dannycoates
Copy link
Contributor

This was done it #2368

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
Sprint 54.3
Development

No branches or pull requests
3 participants
@ianb @dannycoates @ckprice