New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fcron: 3.1.2 -> 3.2.1 #23320
fcron: 3.1.2 -> 3.2.1 #23320
Conversation
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @edolstra and @MarcWeber to be potential reviewers. |
I removed: |
The module fails to start on my system (stops with 0 after being started)
|
Hmm have to look at the module I guess. Because I had to remove root, wonder if hat caused the error |
@ndowens the modules needs to add a |
@ndowens not really, Please test if your changes actually work before opening pull requests |
@Mic92 I did; I used build-vm; the first time I seen error in the log by journalctl and then I updated the module, by adding fcron user and I seen no error in the journal and it seemed as fcron was running when I looked at ps -a |
|
Sorry, I thought it worked, I tested it as much I understood it; I never really experienced cron jobs or anything; so I have very limited experience in that area. I just knew that before I added the user, journal had red error for it, and after I added user I didnt see any error; so thought it was fixed |
Motivation for this change
Update
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)