Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fcron: 3.1.2 -> 3.2.1 #23320

Closed
wants to merge 1 commit into from
Closed

fcron: 3.1.2 -> 3.2.1 #23320

wants to merge 1 commit into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Mar 1, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @domenkozar, @edolstra and @MarcWeber to be potential reviewers.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 1, 2017

I removed:
"--with-username=root"
"--with-groupname=root"
Because fcron will no longer build using root as a user

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

services.fcron.enable = true;

The module fails to start on my system (stops with 0 after being started)

Mar 02 10:37:31 turingmachine systemd[1]: Starting fcron daemon...
Mar 02 10:37:31 turingmachine fcron-pre-start[9395]: 2017-03-02 10:37:31 ERROR user "fcron" is not in passwd file. Aborting.: Success
Mar 02 10:37:31 turingmachine fcron-pre-start[9395]: 2017-03-02 10:37:31 ERROR fcron child aborted: this does not affect the main fcron daemon, but
Mar 02 10:37:31 turingmachine systemd[1]: Started fcron daemon.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 2, 2017

Hmm have to look at the module I guess. Because I had to remove root, wonder if hat caused the error

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2017

@ndowens the modules needs to add a fcron user I guess.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 3, 2017

@Mic92 #23413 fixes this

@Mic92 Mic92 closed this in 947815f Mar 5, 2017
@Mic92
Copy link
Member

Mic92 commented Mar 5, 2017

@ndowens not really, Please test if your changes actually work before opening pull requests

Mic92 added a commit that referenced this pull request Mar 5, 2017
fixes #23320 #23413

(cherry picked from commit 947815f)
@ndowens
Copy link
Contributor Author

ndowens commented Mar 5, 2017

@Mic92 I did; I used build-vm; the first time I seen error in the log by journalctl and then I updated the module, by adding fcron user and I seen no error in the journal and it seemed as fcron was running when I looked at ps -a

@Mic92
Copy link
Member

Mic92 commented Mar 5, 2017

/var/spool/fcron was not owned by the fcron users for instance. So adding new crontabs would not have worked.

@ndowens
Copy link
Contributor Author

ndowens commented Mar 5, 2017

Sorry, I thought it worked, I tested it as much I understood it; I never really experienced cron jobs or anything; so I have very limited experience in that area. I just knew that before I added the user, journal had red error for it, and after I added user I didnt see any error; so thought it was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants