Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xurls: 0.8.0 -> 1.1.0 #23300

Merged
merged 1 commit into from Mar 1, 2017
Merged

xurls: 0.8.0 -> 1.1.0 #23300

merged 1 commit into from Mar 1, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Feb 28, 2017

Motivation for this change

Update to latest

Things done
  • [ x] Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • Linux
  • [ x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • [ x] Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @k0ral and @dezgeg to be potential reviewers.

@peterhoeg
Copy link
Member

It's xurls not xul.

@ndowens ndowens changed the title xul: 0.8.0 -> 1.1.0 xurls: 0.8.0 -> 1.1.0 Mar 1, 2017
@ndowens
Copy link
Contributor Author

ndowens commented Mar 1, 2017

woops @peterhoeg fixed

@peterhoeg peterhoeg merged commit 9a2b234 into NixOS:master Mar 1, 2017
@peterhoeg
Copy link
Member

Thanks for your work on this!

FYI, if you do [ x] or [x ] in a comment it will not render as a checkbox. It has to be [x].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndowens @mention-bot @peterhoeg