Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flashplayer: 24.0.0.221 -> 25.0.0.127 [Critical security fix] #23889

Merged
merged 1 commit into from Mar 14, 2017
Merged

flashplayer: 24.0.0.221 -> 25.0.0.127 [Critical security fix] #23889

merged 1 commit into from Mar 14, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 14, 2017

Motivation for this change
  • Critical security fixes.
  • Other bug fixes.
  • Separate HTTP and HTTPS permissions for Camera and Microphone

https://helpx.adobe.com/flash-player/release-note/fp_25_air_25_release_notes.html
https://helpx.adobe.com/security/products/flash-player/apsb17-07.html

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested:

  • Build packages
    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
  • Play a video with Firefox (x86_64)
  • Check the version with Firefox (x86_64) http://www.adobe.com/software/flash/about/
  • Play a flash animation with sound with flashplayer-standalone-debugger (x86_64)

@joachifm joachifm merged commit c377267 into NixOS:master Mar 14, 2017
@joachifm
Copy link
Contributor

I'll cherry-pick as well.

joachifm pushed a commit that referenced this pull request Mar 14, 2017
@taku0 @joachifm
flashplayer: 24.0.0.221 -> 25.0.0.127 (#23889)
3c61bc1 
(cherry picked from commit c377267)
joachifm pushed a commit that referenced this pull request Mar 14, 2017
@taku0 @joachifm
flashplayer: 24.0.0.221 -> 25.0.0.127 (#23889)
895ea66 
(cherry picked from commit c377267)
@joepie91
Copy link
Contributor

joepie91 commented Mar 15, 2017 •
edited

Has this made it into 16.09 yet? I'm still seeing the below when rebuilding:

curl: (22) The requested URL returned error: 404 Not Found
error: cannot download flash_player_npapi_linux.x86_64.tar.gz from any mirror
builder for ‘/nix/store/xyc6appv10076qla0s25bp1zbbj1whsc-flash_player_npapi_linux.x86_64.tar.gz.drv’ failed with exit code 1
cannot build derivation ‘/nix/store/7k3q8ip9ckfc4v18kzm8258kla0hi0dc-flashplayer-24.0.0.221.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/j548rba5sr3m1r31j2qhb3b83892azw1-firefox-51.0.1.drv’: 1 dependencies couldn't be built

@Mic92
Copy link
Member

Mic92 commented Mar 15, 2017

@joepie91 its in the release branch of 16.09, maybe the channel is not finish building yet.

@joepie91
Copy link
Contributor

Where can I track when it's finished building (to the point that it'll be available to install)? I've had to remove the Flash plugin from my configuration for the time being :/

@joachifm
Copy link
Contributor

@joepie91 you can follow along at https://hydra.nixos.org/jobset/nixos/release-16.09, but it can be hard to predict when/if the channel will move forward. As an alternative, you can temporarily switch to a -small channel.

peterhoeg pushed a commit to peterhoeg/nixpkgs that referenced this pull request Mar 16, 2017
@taku0 @peterhoeg
flashplayer: 24.0.0.221 -> 25.0.0.127 (NixOS#23889)
ba4b986
kamilchm added a commit to kamilchm/nixpkgs that referenced this pull request Mar 16, 2017
@kamilchm
chromium: flashplayer: 24.0.0.221 -> 25.0.0.127
df3044c 
[Critical security fix]
NixOS#23889
@kamilchm kamilchm mentioned this pull request Mar 16, 2017
Merged
7 tasks
@kamilchm
Copy link
Member

Can we have flashplayer in one reusable place? This is the second time I needed to patch chromium in a separate PR.

kamilchm added a commit to kamilchm/nixpkgs that referenced this pull request Mar 16, 2017
@kamilchm
chromium: flashplayer: 24.0.0.221 -> 25.0.0.127
928353d 
[Critical security fix]
NixOS#23889
Mic92 pushed a commit that referenced this pull request Mar 16, 2017
@kamilchm @Mic92
chromium: flashplayer: 24.0.0.221 -> 25.0.0.127
91e8742 
[Critical security fix]
#23889

(cherry picked from commit 15e49a95d9c9bdf1efcf08d266f491e54dd51cfb)
Mic92 pushed a commit that referenced this pull request Mar 16, 2017
@kamilchm @Mic92
chromium: flashplayer: 24.0.0.221 -> 25.0.0.127
98cc721 
[Critical security fix]
#23889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@taku0 @joachifm @joepie91 @Mic92 @kamilchm