Use default Type::STREAM for type. #4146

txdv · 2017-03-14T15:00:55Z

It can't be nil, it has to be an integer value.

require "socket"

puts Socket::Addrinfo.resolve("localhost", 27015).first.ip_address.address

throws

Error in info.cr:3: instantiating 'Socket::Addrinfo:Class#resolve(String, Int32)'

puts Socket::Addrinfo.resolve("localhost", 27015).first.ip_address.address
                      ^~~~~~~

in /opt/crystal/src/socket/addrinfo.cr:28: can't restrict Nil to Type

    def self.resolve(domain, service, family : Family? = nil, type : Type = nil, protocol : Protocol = Protocol::IP, timeout = nil) : Array(Addrinfo)

which is defined here

I changed the type to Type? and made sure it would use a default value further down.

It can't be nil, it has to be an integer value.

txdv · 2017-03-14T15:04:35Z

Looking at the spec ... maybe it was intended to not specify any default value at all?

But then the default value of nil doesn't make sense and it should be an argument at the beginning of the argument list.

ysbaddaden · 2017-03-14T16:10:09Z

This is by design. The type argument is required. It's set to nil but forced to be Type so it's usable as a named argument (i.e. resolve(domain, "http", type: Socket::Type::STREAM) but still required. You'll may prefer to use Addrinfo.tcp or Addrinfo.udp instead.

I suppose we could remove the default nil assignment, since Crystal now allows any argument to be a named argument.

txdv · 2017-03-14T17:23:40Z

Hm, I was just confused, because ruby had just an interface like resolve(string), i guess this represents the underlying protocol better

Use default Type::STREAM for type.

e9a42e6

It can't be nil, it has to be an integer value.

txdv closed this Mar 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use default Type::STREAM for type. #4146

Use default Type::STREAM for type. #4146

txdv commented Mar 14, 2017

txdv commented Mar 14, 2017 •

edited

ysbaddaden commented Mar 14, 2017 •

edited

txdv commented Mar 14, 2017

Use default Type::STREAM for type. #4146

Use default Type::STREAM for type. #4146

Conversation

txdv commented Mar 14, 2017

txdv commented Mar 14, 2017 • edited

ysbaddaden commented Mar 14, 2017 • edited

txdv commented Mar 14, 2017

txdv commented Mar 14, 2017 •

edited

ysbaddaden commented Mar 14, 2017 •

edited