timewarrior: patch to install all themes; use default install target. #23886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dtzWill, thanks for your PR! By analyzing the history of the files in this pull request, we identified @matthiasbeyer and @regnat to be potential reviewers. |
dtzWill
changed the title
|
FYI: Chatted with the great taskwarrior/timewarrior team on IRC, they say the issue fixed by this patch is known and has already been fixed upstream and will be part of 1.1.0. |
matthiasbeyer
approved these changes
Mar 15, 2017
|
Why don't we update taskwarrior to 1.1.0 then? |
|
It's not released yet AFAICT. We could use a dev version but I think that
would be overkill for grabbing a few more files during install.
I'm happy waiting until it's released, although I have no idea if that's
expected to happen soon or not.
…On Wed, Mar 15, 2017, 3:31 AM Matthias Beyer ***@***.***> wrote:
Why don't we update taskwarrior to 1.1.0 then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23886 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAx4sluebnzLhUD_TINKckDIQTu6pgkaks5rl6HhgaJpZM4MciV->
.
|
Ah, right. |
|
I also back port this fix to 17.03. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Simpler install phase (presumably earlier timewarrior versions had a missing or broken install target),
fixes installation of docs which I discovered since they ship suggested themes as docs :).
Add patch to install all themes, not just 'dark.theme'.
Will be submitting patch upstream soon.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)