Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ocsigen_start #23487

Closed
wants to merge 3 commits into from
Closed

Conversation

FlorentBecker
Copy link
Contributor

Motivation for this change

This updates to the latest versions of the ocsigen project. This allows nix users to follow their "recommended workflow".

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@FlorentBecker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vbgl, @ericbmerritt and @7c6f434c to be potential reviewers.

@vbgl
Copy link
Contributor

vbgl commented Mar 4, 2017

The two attributes ocsigen_server and ocsigen_server_pgocaml have the same value (in the second, you explicitly set the pgocaml parameter to its default value). If you really want a version of ocsigenserver build without PostgreSQL support, then you may add a call with { pgocaml = null; }. An other possibility is to add a boolean argument, say pgSupport, that defaults to false, and that is set to true in the ocsigen_server_pgocaml attribute.

Please do not introduce arbitrary mismatches between package name, attribute name, directory name, etc. For instance, you should use ocsigen-toolkit everywhere (with a dash).

Is ocsigen-i18n an OCaml library? If not, then createFindlibDestdir should be false. Otherwise, something is wrong in the build since nothing is installed in that directory.

buildOCaml sets the meta.platforms for you: no need to override it.

@vbgl
Copy link
Contributor

vbgl commented Mar 17, 2017

Cherry-picked the first commits as e3a77dd, 9fd4966, and bc26feb.

I think the packages for ocsigen-start and ocsigen-i18n are not yet ready.

@FlorentBecker
Copy link
Contributor Author

Do you mean the software or the packaging?

@vbgl
Copy link
Contributor

vbgl commented Mar 18, 2017

I’m talking about the packaging.

About ocsigen-start, there should be a convenient way to tell eliom-distillery where the template is.

$ eliom-distillery -template os.pgocaml
eliom-distillery: Not a known template name: "os.pgocaml".

About ocsigen-i18n, is it a library? does it belong to ocaml-packages.nix?

@FlorentBecker FlorentBecker changed the title Update to latest eliom + add ocsigen_start add ocsigen_start Mar 18, 2017
@vbgl
Copy link
Contributor

vbgl commented Mar 20, 2017

Merged in ac87d9b, 0910738, and e4d3974. Thanks.

@vbgl vbgl closed this Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants