Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume groups using YouTube are always available #124

Merged
merged 2 commits into from Mar 4, 2017

Conversation

joeladdison
Copy link
Member

Instead of registering a fake endpoint for each group using YouTube,
assume that the stream is always available. This effectively registers
a fake endpoint, but does not store it to the database, as there is no
need to do so.

Instead of registering a fake endpoint for each group using YouTube,
assume that the stream is always available. This effectively registers
a fake endpoint, but does not store it to the database, as there is no
need to do so.
@joeladdison joeladdison merged commit 6432319 into timvideos:master Mar 4, 2017
@joeladdison joeladdison deleted the yt-no-register branch March 4, 2017 05:06
@@ -39,6 +39,9 @@ sudo pip install virtualenv
Running a test server
=====================

Start by setting the ``STATIC_ROOT`` within ``website/settings.py`` to be the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had to do it everytime I've set up a local version for testing, under both Ubuntu and macOS. Maybe there is another place I should be putting it? Or do you think it should happen automatically?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think STATIC_ROOT should probably be set to somewhere like a temp directory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like that is the case after reading some more.

We appear to be running python manage.py collectstatic --noinput as part of the build steps before stating a dev server. This requires STATIC_ROOT to be set. I'm not sure if we need to do this, because there is a built in static file handler when running in DEBUG mode (which the dev server appears to be doing). So maybe we should not run collectstatic anymore and just use the default handler in dev mode?
Otherwise, maybe we should set the default to be something like '/tmp/streaming-static', so nothing needs to be configured for development? That should work across most systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants