eclipse: don't use webkitgtk2, fix dependency passing #23501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switched from callPackage to import so that dependencies are passed instead of being grabbed from pkgs.
Tell callPackage not not include webkitgtk2 due to the fact that it has multiple vulnerabilities.
|
@zraexy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @MarcWeber and @rycee to be potential reviewers. |
bjornfor
approved these changes
Mar 4, 2017
zraexy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Made eclipse 'import' the builder instead of using 'callPackage' so it uses the dependencies it is passed.
Told eclipse to not use webkitgtk2 by default.
This fixes the issue of eclipse trying to use webkitgtk2 and failing because it has vulnerabilities.
This should be ported to 17.03
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)