Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-sip: 4.18.1 -> 4.19.1 #23484

Closed
wants to merge 1 commit into from
Closed

python-sip: 4.18.1 -> 4.19.1 #23484

wants to merge 1 commit into from

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Mar 4, 2017 •
edited

Motivation for this change

Update qutebrowser dependencies for #23244

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NickHu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh, @abbradar and @lovek323 to be potential reviewers.

@NickHu NickHu mentioned this pull request Mar 4, 2017
Closed
7 tasks
@FRidh
Copy link
Member

FRidh commented Mar 4, 2017

sip is already in #23485 so closing this one.

@FRidh FRidh closed this Mar 4, 2017
@NickHu NickHu deleted the sip branch July 18, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickHu @mention-bot @FRidh