phonon-gstreamer-backend: Hardcode GStreamer plugin paths #23504
Conversation
| gst-libav | ||
| ]); | ||
| postPatch = '' | ||
| substituteInPlace gstreamer/backend.cpp --subst-var gstPluginPaths |
There was a problem hiding this comment.
Since the patch file is so small and it relies on a generated value from Nix, why not inline it and template the gstPluginPaths? That way you don't need the substituteInPlace step.
There was a problem hiding this comment.
I don't understand what that means...
There was a problem hiding this comment.
What I mean is, you could also write it like this to eliminate the substitution (particularly so since the patch is a small one):
patches = [
(writeTextFile
{ name = "gst-plugins-paths.patch";
text = ''
Index: phonon-gstreamer-4.9.0/gstreamer/backend.cpp
===================================================================
--- phonon-gstreamer-4.9.0.orig/gstreamer/backend.cpp
+++ phonon-gstreamer-4.9.0/gstreamer/backend.cpp
@@ -85,6 +85,8 @@ Backend::Backend(QObject *parent, const
"--gst-debug-no-color"
};
+ qputenv("GST_PLUGIN_PATH_1_0", "${gstPluginsPath}");
+
int argc = sizeof(args) / sizeof(*args);
char **argv = const_cast<char**>(args);
GError *err = 0;
'';
})
];
| @@ -182,16 +182,6 @@ in | |||
|
|
|||
| environment.variables = { | |||
| # Enable GTK applications to load SVG icons | |||
There was a problem hiding this comment.
Is this comment still relevant (asking because I don't know) now that L185 - L194 is moved to the derivation?
There was a problem hiding this comment.
Yes; that comment was supposed to be for GDK_PIXBUF_MODULE_FILE below!
ttuegel
force-pushed
the
phonon-gstreamer
branch
from
c43e83d
to
edd4335
Compare
|
I split the difference by using the pre-processor and |
|
I like your latest way of doing it better and I agree with you. 👍 |
Motivation
The existing GStreamer backend for Phonon requires extensive runtime configuration to find the requisite plugins. Phonon-based applications are not usable except in KDE on NixOS.
The plugin paths are now hardcoded into the backend. To fix Phonon-based applications outside KDE, we only need the package maintainers to include the backend and wrap their package with
makeQtWrapper.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)