New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiling ipynb now looks for default jupyter configuration #2688
Conversation
…o knowsuchagency-master
@@ -4,6 +4,7 @@ New in master | |||
Features | |||
-------- | |||
|
|||
* Add Jupyter config as dependency for jupyter posts (by @knowsuchagency) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What’s the purpose of this attribution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New contributor encouragement :-)
nikola/plugins/compile/ipynb.py
Outdated
abs_path = os.path.join(parent, file) | ||
with open(abs_path) as config_file: | ||
config.update(json.load(config_file)) | ||
except FileNotFoundError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except OSError:
for py2 compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
This is a followup from #2650
For those, like @knowsuchagency, who use the jupyter extensions, specifically python markdown, this makes it so Nikola will automatically look to see if users have edited the configuration files nbconvert normally looks at when compiling notebooks itself.
Thus if you have a markdown cell that jupyter normally converts to 2 from {{ 1 + 1 }} in your notebook, you'll see the former rather than the later.