tome4: 1.4.6 -> 1.4.9 #23488
Closed
tome4: 1.4.6 -> 1.4.9 #23488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewed points
|
joachifm
reviewed
Mar 4, 2017
pkgs/games/tome4/default.nix
Outdated
| premake4 gmake | ||
| ''; | ||
| makeFlags = [ "config=release" ]; | ||
| installPhase = '' | ||
| install -Dm755 t-engine $out/opt/tome4/t-engine | ||
| echo "#!/{bash}/bin/sh" >> tome4 |
There was a problem hiding this comment.
You can also do ${stdenv.shell} here, or simply use /bin/sh and rely on shebang patching to fixup the path.
There was a problem hiding this comment.
Ok, changed to /bin/sh
|
Merged with some cosmetical changes in 8cbba14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
update and fix compile failure
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)maintainer @Chattered