Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix .sif saving inkscape #23494

Closed
wants to merge 1 commit into from
Closed

Conversation

MarcWeber
Copy link
Contributor

Motivation for this change

file -> save as -> .sif reports lxml python library not found. This fixes it.
Broken since 7ff1544

@mention-bot
Copy link

@MarcWeber, thanks for your PR! By analyzing the history of the files in this pull request, we identified @taku0, @aszlig and @edolstra to be potential reviewers.

Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

On the mailing list I explained how this can be fixed. This is somewhat in the right direction, but actually mixing two solutions.

There are two solutions:

  1. create a wrapper that adds the Python interpreter with set PATH and makes the modules available with set PYTHONPATH.
  2. create an environment that has an interpreter with all modules in it and make it available with set PATH

The preferred solution is 2, because using PYTHONPATH occasionally causes issues. Furthermore, using prefix PYTHONPATH should absolutely not be done; there is an issue about that on this tracker.

@FRidh FRidh self-assigned this Mar 5, 2017
@jtojnar
Copy link
Contributor

jtojnar commented Oct 20, 2018

Most likely fixed by #26293

@jtojnar jtojnar closed this Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants