ripgrep: install man-page #23694
Merged
ripgrep: install man-page #23694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the `ripgrep` package to install the tool's manual page.
I have tested this commit per nixpkgs manual section 11.1 ("Making
patches").
|
lgtm |
ttuegel
reviewed
Mar 12, 2017
| @@ -15,6 +15,11 @@ buildRustPackage rec { | |||
|
|
|||
| depsSha256 = "0q68qyl2h6i0qsz82z840myxlnjay8p1w5z7hfyr8fqp7wgwa9cx"; | |||
|
|
|||
| preFixup = '' | |||
| mkdir -p "$out/man/man1" | |||
There was a problem hiding this comment.
Should this be $out/share/man/man1?
There was a problem hiding this comment.
I noted that the fixup phase "moves the man/, doc/ and info/ subdirectories of $out to share/", and assumed that meant that $out/man is where the system wants me to put man-pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
ripgreppackage to install the tool's manual page.I have tested this commit per nixpkgs manual section 11.1 ("Making
patches").
cc @tailhook