Initial commit of Google's packetdrill #23679
Conversation
| @@ -0,0 +1,25 @@ | |||
| { pkgs ? import <nixpkgs> {} }: | |||
There was a problem hiding this comment.
Please do not pass the entire package set; specify inputs as parameters.
| sha256 = "09sqiakmn63idfjhy2ddf1456sfhi8yhsbp8lxvc1yfjikjxwwbc"; | ||
| }; | ||
| setSourceRoot = '' | ||
| export sourceRoot=$(realpath */gtests/net/packetdrill) |
There was a problem hiding this comment.
Have you tried just sourceRoot = "gtests/net/packetdrill"?
| { pkgs ? import <nixpkgs> {} }: | ||
| pkgs.stdenv.mkDerivation { | ||
| version = "1.0"; | ||
| name = "packetdrill-${version}"; |
There was a problem hiding this comment.
The attrset passed to mkDerivation must be rec for values to refer to other attrs in the same set.
There was a problem hiding this comment.
That was a last minute change. Will fix.
| enableParallelBuilding = true; | ||
|
|
||
| meta = { | ||
| description = "The packetdrill scripting tool enables quick, precise tests for entire TCP/UDP/IPv4/IPv6 network stacks, from the system call layer down to the NIC hardware"; |
There was a problem hiding this comment.
This is too long. Please review the packaging guidelines.
| meta = { | ||
| description = "The packetdrill scripting tool enables quick, precise tests for entire TCP/UDP/IPv4/IPv6 network stacks, from the system call layer down to the NIC hardware"; | ||
| homepage = https://github.com/google/packetdrill; | ||
| license = "GPLv2"; |
There was a problem hiding this comment.
k
nix-repl> stdenv.lib.licenses.gpl2
{ fullName = "GNU General Public License v2.0 only"; shortName = "gpl2"; ...}
| description = "The packetdrill scripting tool enables quick, precise tests for entire TCP/UDP/IPv4/IPv6 network stacks, from the system call layer down to the NIC hardware"; | ||
| homepage = https://github.com/google/packetdrill; | ||
| license = "GPLv2"; | ||
| platforms = stdenv.lib.platforms.gnu; |
There was a problem hiding this comment.
Because I copied it from telnet :) will fix.
|
@joachifm ready for updated review |
|
but that githash will change with every update, and the -src at the end can change due to how you fetch the source using a * will catch whatever it is, and only one directory will contain gtests and match it |
|
Merged. Thank you |
|
@joachifm cheers 🍻 |
Motivation for this change
Perform full network stack testing with the nix package manager.
cc @cleverca22
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)