Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

angband: Fix build by enabling stats frontend. #23692

Closed
wants to merge 1 commit into from

Conversation

sh01
Copy link
Contributor

@sh01 sh01 commented Mar 10, 2017

Motivation for this change

Angband currently fails to build from source, since the C source generated in the absence of any frontend modules fails -pedantic (which is forced by its ./configure).
I work around this by enabling the stats frontend, which has the side effect of providing slightly more features. This change does not introduce any additional dependencies.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@sh01, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joachifm and @globin to be potential reviewers.

@sh01
Copy link
Contributor Author

sh01 commented Mar 10, 2017

Whoops, never mind this. I messed up my testing; I'll go back and come up with something that actually works.

@sh01 sh01 closed this Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants