Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e31f5673da9b
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 74c50957a4d4
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 24, 2017

  1. Actually cache the idTest on the module.

    This was assigning to the local variable, so the  would be created ever time this is called.
    snowp committed Feb 24, 2017
    Copy the full SHA
    24a14e4 View commit details
  2. Merge pull request #4507 from snowp/fix-idtest-cache

    Actually cache the idTest on the module.
    headius authored Feb 24, 2017
    Copy the full SHA
    74c5095 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 core/src/main/java/org/jruby/RubyModule.java
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/RubyModule.java
Original file line number Diff line number Diff line change
@@ -302,7 +302,7 @@ public void addIncludingHierarchy(IncludedModule hierarchy) {
public MethodHandle getIdTest() {
MethodHandle idTest = this.idTest;
if (idTest != null) return idTest;
return idTest = newIdTest();
return this.idTest = newIdTest();
}

protected MethodHandle newIdTest() {